Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved card design #72

Merged
merged 2 commits into from
Aug 19, 2021

Conversation

suveshmoza
Copy link
Contributor

I have updated the card layout and also made them to have same height.

@netlify
Copy link

netlify bot commented Aug 19, 2021

✔️ Deploy Preview for helpafamily-margarita-humanitarian ready!
Built without sensitive environment variables

🔨 Explore the source changes: ebe904c

🔍 Inspect the deploy log: https://app.netlify.com/sites/helpafamily-margarita-humanitarian/deploys/611e40d0b4ccda00093cc76a

😎 Browse the preview: https://deploy-preview-72--helpafamily-margarita-humanitarian.netlify.app

@RedFox0x20
Copy link
Collaborator

All looks good, much nicer card design that works well with the changes in #61

The only issue is the Health Education Workshop card where on a desktop display, the button text overflows slightly at the bottom.

@audreyfeldroy
Copy link
Member

I love your work here @suveshmoza and the code looks very good.

About the Health Education Workshop card, I noticed that before. I think I can just shorten the wording as a quick fix 🙂

@audreyfeldroy
Copy link
Member

Thanks so much @RedFox0x20 for thoughtfully reviewing both this and #68 🙏

Copy link
Member

@audreyfeldroy audreyfeldroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good. The suggested change I made is technically out of scope of this PR...just adding it here to address @RedFox0x20's comment before I forget.

components/HealthWorkshopCard.js Outdated Show resolved Hide resolved
@audreyfeldroy audreyfeldroy merged commit 6a11f8b into margaritahumanitarian:main Aug 19, 2021
@audreyfeldroy
Copy link
Member

Just wanted to say that I truly appreciate how thoughtful you were about choosing such nice photos. And that the design you created is really beautiful. Thank you @suveshmoza.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants