Modified checkbox behaviour #45 #47
Conversation
The checkbox behaviour was modified such that, when the `Anyone in need` option is selected, all other checkboxes will be unchecked. This prevents any messy donation messages, in addition to being more user-friendly.
|
✔️ Deploy Preview for helpafamily-margarita-humanitarian ready! 🔨 Explore the source changes: 254da79 🔍 Inspect the deploy log: https://app.netlify.com/sites/helpafamily-margarita-humanitarian/deploys/611b710cb4b0cb00085023f7 😎 Browse the preview: https://deploy-preview-47--helpafamily-margarita-humanitarian.netlify.app |
I added this comments while reviewing PR #47, to help myself understand how MainDonationForm works.
|
@RedFox0x20 I appreciate your thoughtfulness in this PR so much! I added comments as I was reviewing this to help my understanding. Really excellent work. Thank you. |
|
Hmm, in the Netlify deploy preview when I click "Donate", I get this error in the JS console upon submission:
This happens whether I toggle "Anyone in Need" on or off. Looking into it... |
|
I'll try submitting a different PR and see if the same error occurs. It might be related to our Netlify configuration, not to this PR. |
|
I saw that a totally unrelated PR also has this form submission 502 error. So I think the error is unrelated to this PR, and I'll go ahead and merge this. Thanks again @RedFox0x20! |
This fixes an issue I recognised shortly after the previous PR was merged.
The checkbox behaviour was modified such that, when the
Anyone in needoption is selected, all other checkboxes will be checked. This prevents any messy donation messages, in addition to being more user-friendly. An additional classdonate-form-checkboxwas added to these elements to ensure future development of the site is not interfered with by these changes.