Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Done add Laptopforfamiliescard #48

Merged

Conversation

briankarlsayen
Copy link
Contributor

Still new to contributing, kindly check if I did it right. Thanks

@netlify
Copy link

netlify bot commented Aug 17, 2021

✔️ Deploy Preview for helpafamily-margarita-humanitarian ready!
Built without sensitive environment variables

🔨 Explore the source changes: 24b2fb8

🔍 Inspect the deploy log: https://app.netlify.com/sites/helpafamily-margarita-humanitarian/deploys/611b86b9b30780000761be0d

😎 Browse the preview: https://deploy-preview-48--helpafamily-margarita-humanitarian.netlify.app

Copy link
Member

@audreyfeldroy audreyfeldroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@briankarlsayen Thank you for your contribution! I've reviewed your PR in detail, requesting a few small changes. Overall it looks very good!

components/LaptopForFamiliesCard.js Outdated Show resolved Hide resolved
components/LaptopForFamiliesCard.js Outdated Show resolved Hide resolved
components/LaptopForFamiliesCard.js Outdated Show resolved Hide resolved
components/LaptopForFamiliesCard.js Outdated Show resolved Hide resolved
@audreyfeldroy
Copy link
Member

audreyfeldroy commented Aug 17, 2021

I'll be in chat in https://app.element.io/#/room/#mhf:matrix.org for a few more minutes in case you have questions or need guidance.

After that I'll go to bed since it's late here in Los Angeles, and tomorrow I'll check back here to help you further @briankarlsayen.

@audreyfeldroy
Copy link
Member

Just a bit of friendly clarification...on your end you'll need to:

  1. Pull to get the commit I made with my text changes
  2. Change the indentation to 2 spaces in components/LaptopForFamiliesCard.js
  3. Commit and push your work to your donatelaptopcard branch

Hope this helps, and post here if you get stuck on any part of this.

@briankarlsayen
Copy link
Contributor Author

Hi, done updating indention.

Copy link
Member

@audreyfeldroy audreyfeldroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good! I can merge this.

components/LaptopForFamiliesCard.js Outdated Show resolved Hide resolved
@audreyfeldroy
Copy link
Member

I checked the Netlify deploy preview and the Laptop for Families card looks perfect 👍

@audreyfeldroy audreyfeldroy merged commit 13f1282 into margaritahumanitarian:main Aug 17, 2021
@audreyfeldroy
Copy link
Member

I've merged this PR. Thank you so much for contributing @briankarlsayen! You did a really great job and I appreciate your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants