Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linting issues in thankyou.js #79

Merged
merged 1 commit into from
Aug 19, 2021
Merged

Fix linting issues in thankyou.js #79

merged 1 commit into from
Aug 19, 2021

Conversation

RedFox0x20
Copy link
Collaborator

This should have fixed the linting issues mentioned in #78 It is preferable to merge this first so that the form functionality in #78 can be checked on the Netlify host as the donate button does not work in my local instance.

@netlify
Copy link

netlify bot commented Aug 19, 2021

✔️ Deploy Preview for helpafamily-margarita-humanitarian ready!
Built without sensitive environment variables

🔨 Explore the source changes: 40ea615

🔍 Inspect the deploy log: https://app.netlify.com/sites/helpafamily-margarita-humanitarian/deploys/611e725d6bbedd00076aa85e

😎 Browse the preview: https://deploy-preview-79--helpafamily-margarita-humanitarian.netlify.app

@audreyfeldroy
Copy link
Member

Thanks a ton for catching this and submitting a fix @RedFox0x20. I realize I should have linted and run Prettier manually when reviewing that PR.

@audreyfeldroy audreyfeldroy merged commit e4d9f4d into margaritahumanitarian:main Aug 19, 2021
@audreyfeldroy
Copy link
Member

I also really appreciate the fact that you made this a separate atomic PR. That really helped me review this and get it in fast.

@RedFox0x20
Copy link
Collaborator Author

No worries! Considered what you had mentioned in a previous message regarding PR scopes, thought it seemed the best way to go through.

@RedFox0x20 RedFox0x20 deleted the fix-linting-errors branch August 19, 2021 18:51
tof-tof added a commit to tof-tof/helpafamily that referenced this pull request Aug 19, 2021
using margaritahumanitarian#79 fix to fix deploy errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants