Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use transpiled esm for app bundles #302

Merged
merged 1 commit into from
May 6, 2024

Conversation

shamilovtim
Copy link
Contributor

for consideration as an alternative to #294

rather than requiring downstream projects to use typescript and transpile typescript using their own project's settings, we should transpile the typescript in this project and ship ESM with declarations, sourceMaps, and declarationMaps

Copy link
Collaborator

@boorad boorad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@boorad boorad merged commit 5012754 into margelo:main May 6, 2024
2 checks passed
@shamilovtim shamilovtim deleted the tshamilov/ts-declarations branch May 6, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants