Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: stop global modification. remove quick-base64. modernize podspec. #309

Merged
merged 15 commits into from
May 10, 2024

Conversation

shamilovtim
Copy link
Contributor

@shamilovtim shamilovtim commented May 10, 2024

various project upgrades

  • fix folly errors in new projects
  • remove react native quick base64
  • breaking: users must explicitly call install() in order to modify globals.
  • modernized podspec with latest react native library standards
  • remove unused dependencies from package.json

I left in the modifcations to global.process.nextTick because I didn't want to change any runtime logic with this PR but I think that probably needs a look

Copy link
Collaborator

@boorad boorad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Some comments in Discord.

src/index.ts Outdated Show resolved Hide resolved
@boorad boorad mentioned this pull request May 10, 2024
@boorad boorad merged commit 48b0bef into margelo:main May 10, 2024
6 checks passed
@shamilovtim shamilovtim deleted the tshamilov/globals branch May 12, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants