Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: minSdkVersion being below that of the latest react native release #318

Merged
merged 1 commit into from
May 15, 2024

Conversation

GNUGradyn
Copy link
Contributor

@GNUGradyn GNUGradyn commented May 15, 2024

fixes #315

@boorad boorad changed the title FIx minSdkVersion being below that of the latest react native release fix: minSdkVersion being below that of the latest react native release May 15, 2024
Copy link
Collaborator

@boorad boorad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Not sure it's completely necessary, as users could change their minimum app versions, but this may stop at least some of the build error tickets from showing up 🚀

@boorad boorad merged commit c75493d into margelo:main May 15, 2024
1 check passed
@GNUGradyn
Copy link
Contributor Author

They'd have to decrease it, which is not ideal

@shamilovtim
Copy link
Contributor

Note this is for the example app so it does nothing for end user projects.

@boorad
Copy link
Collaborator

boorad commented May 21, 2024

I see that now... @GNUGradyn how did this PR help your situation? Were you using minSDKVersion in your project?

I've opened #324 to track a possible new fix.

I also see this: https://github.com/margelo/react-native-quick-crypto/blob/main/android/build.gradle#L107 which should "do the right thing" in the absence of any variables. Not sure why there was an issue unless we had variable name collision.

@GNUGradyn
Copy link
Contributor Author

ah. looks like I updated this in the wrong file for my PR. defaultCOnfig.minSdkVersion in react-native-quick-crypto/android/build.gradle solves the issue. I guess this change was required for the example to work anyway lol. Will make PR for the actual correct file

@GNUGradyn
Copy link
Contributor Author

Ah I see. That field is set when the library is compiled, Not sure why its set to 21 on npm. Something to do with the build environment maybe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants