Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOS build issue #17

Closed
relaxxpls opened this issue Jan 25, 2024 · 5 comments
Closed

IOS build issue #17

relaxxpls opened this issue Jan 25, 2024 · 5 comments

Comments

@relaxxpls
Copy link

relaxxpls commented Jan 25, 2024

Platform iOS
Cloned main on commit 3850942410b9e9d4fcbfc3ca2a8ad601198ec0f4
and got the error

repo/node_modules/react-native-skottie/cpp/JsiSkSkottie.h:11:10 'modules/skottie/include/Skottie.h' file not found
@hannojg
Copy link
Member

hannojg commented Jan 25, 2024

Hey, can you please retest with the latest version? I think it should be fixed. Thanks

@relaxxpls
Copy link
Author

Hey @hannojg, I did. Now i'm getting the below error:
'RNSkIOSView.h' file not found with include; use "quotes" instead

PS: Great work, I'm super stoked to try this package out.

@relaxxpls
Copy link
Author

Update: Upon using quotes instead of Angle bracket, it builds succesfully. But upon running the application and using Skottie, I get a non-std C++ exception

image

@hannojg
Copy link
Member

hannojg commented Jan 25, 2024

Question, why do you install from the git repo and not by installing the package. The packages artifact on npm actually contains stuff that's not present in the repo.

@relaxxpls
Copy link
Author

I had initially installed from the git repo, cause the changes had not been released and I was too eager to give it a try. Later, I installed from the repo.
Now, upon clearing my xcode cache and rebuilding, all errors have vanished.
I really appreciate your quick responses and fixes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants