Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'RNSkiaModule.h' file not found with <angled> include; use "quotes" instead #25

Closed
mmr94 opened this issue Jan 31, 2024 · 29 comments · Fixed by #34
Closed

'RNSkiaModule.h' file not found with <angled> include; use "quotes" instead #25

mmr94 opened this issue Jan 31, 2024 · 29 comments · Fixed by #34

Comments

@mmr94
Copy link

mmr94 commented Jan 31, 2024

simple patch for ios native module

@JimTeva
Copy link

JimTeva commented Feb 1, 2024

Same problem with version 2.1.0. This is strange because user @relaxxxpls encounters the same problem here but seems to get it work by installing the latest version...
My setup is RN 0.72.7 on Xcode 15.2 and use_frameworks! in Podfile.
If I correct the 4 errors related to include, then I get more than 100 errors after...

@hannojg
Copy link
Member

hannojg commented Feb 1, 2024

Can anyone of you please provide a reproduction repository for that issue? Much appreciated, thanks! 😊

@JimTeva
Copy link

JimTeva commented Feb 1, 2024

Here you are.

@idrakimuhamad
Copy link
Contributor

idrakimuhamad commented Feb 5, 2024

I'm having this too in latest version. Downgraded to 2.0.4, also still have it. With Skia 0.1.230 and 0.1.237.

image

@JimTeva
Copy link

JimTeva commented Feb 6, 2024

@hannojg any luck with the repo I provided?

@hannojg
Copy link
Member

hannojg commented Feb 6, 2024

Hey, just checked your reproduction. The issue seems to arise due to the usage of use_frameworks.
Will check if we can get that fixed 😊

@JimTeva
Copy link

JimTeva commented Feb 6, 2024

use_frameworks is now mandatory if we want to use Firebase, so I need that. Thanks @hannojg

@idrakimuhamad
Copy link
Contributor

I also use Firebase, so use_framework is needed unfortunately.

@JimTeva
Copy link

JimTeva commented Feb 15, 2024

@hannojg is there any fix for use_frameworks?

@roy-sandoval
Copy link

I'm having the same issue and also use Firebase

@exzos28
Copy link

exzos28 commented Feb 21, 2024

@hannojg I've tried to fix it, but it looks like a linking problem because Firebase requires linkage static. Do you think we can use angled symbols for both situations?

@hannojg
Copy link
Member

hannojg commented Feb 21, 2024

Is using angle brackets fixing the issue for you? When I tested it fixed this particular build error but then caused a bunch of others.

Is using react-native-skia with Firebase / use_frameworks possible?

@exzos28
Copy link

exzos28 commented Feb 21, 2024

@hannojg I'll test again and let you know

@idrakimuhamad
Copy link
Contributor

idrakimuhamad commented Feb 22, 2024

Shopify/react-native-skia#652 (comment)

Can anyone try this?

Seems already in RNSkia since 183 i believe

@JimTeva
Copy link

JimTeva commented Feb 22, 2024

Shopify/react-native-skia#652 (comment)

Can anyone try this?

Seems already in RNSkia since 183 i believe

It is actually the only workaround at the moment if you want to install react native skia, I've already provided the repository to try here #25 (comment)

@JimTeva
Copy link

JimTeva commented Feb 22, 2024

@hannojg Yes the workaround that @idrakimuhamad mentionned is the one that allows to install skia without errors. The podfile I gave you already includes this workaround

@idrakimuhamad
Copy link
Contributor

Yeah i think we don't actually need the workaround as it's already being part of the pod-spec now(?)

Shopify/react-native-skia#1400

@JimTeva
Copy link

JimTeva commented Feb 22, 2024

@idrakimuhamad I've tried without it and it doesn't work but maybe I did something wrong. Please make a new project and install react native skia and if it works then provide a repository for us thanks

@idrakimuhamad
Copy link
Contributor

Chill. What I meant is that, because i'm using firebase and also Skia in my codebase. I do not have issue when installing Skia nor when building the app, so I did not use the workaround. I only get this error when building the app once skottie are being added.

@thoth-seshat
Copy link

thoth-seshat commented Mar 5, 2024

I'm also running into this same issue:
Running expo:

"@shopify/react-native-skia": "0.1.241",
"expo": "50.0.8",
"react-native-skottie": "^2.1.0",
...

I'll have to fall back to lottie-react-native until I can upgrade to skottie when this is resolved. If anyone is working on it, LMK if you need anymore info. I don't have bandwidth to attempt to find the issue at the moment but can't help test or give feedback.

Screenshot 2024-03-04 at 10 49 14 PM

@themtaysw
Copy link

Screenshot 2024-03-11 at 22 15 23
xdddd

@themtaysw
Copy link

i mean... this error is here for a good moment now, did they abandon the project or what xdd

@JimTeva
Copy link

JimTeva commented Mar 20, 2024

@hannojg 🥺

@ejkkan
Copy link

ejkkan commented Mar 22, 2024

Also seeing this. Would be great with a fix asap!

@amrathhugo
Copy link

Can someone help with any workaround for this issue for now?
Thanks

@kadiraydinli
Copy link

Is there any progress on this issue?

@hannojg
Copy link
Member

hannojg commented May 4, 2024

Should be fixed in version https://github.com/margelo/react-native-skottie/releases/tag/v2.1.1

@idrakimuhamad
Copy link
Contributor

Thanks. I'm able to build the app as of v2.1.1, though I'm getting some other crashes related to my lottie file. I will open another ticket.

@JimTeva
Copy link

JimTeva commented May 7, 2024

Thank you very much @hannojg (building ok with React-native@0.72.6 + @shopify/react-native-skia@1.2.3 and react-native-skottie@2.1.4 - I mentionned this because updating skia was very important also)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet