Implement Scc

[marhel]

Please implement the instruction for Set Conditionally. See implementation of Bcc. For more information, please read the instruction contribution guidelines

[emoon]

I can take this

[emoon]

I have started to work on this but I have a strange issue

emoon@810ec28

I have started with implementing shi (dn) but when I try to run the qc test for this the instruction never gets called. I'm sure I have missed something stupid but not sure what it is.

[marhel]

I made the mistake of swapping (or, not swapping, rather) the arguments to the qc-macro a few times. It's easily done, and with the mask and the match reversed, it won't call the intended instruction. We should probably made the qc and op_handler macros have their arguments in the same order, or find a way to make this mistake not typecheck.

[emoon]

Seems I forgot the MASK_OUT_Y here (doh!)

[marhel]

Also, please do a test for implementing the correct op-constant, like at the bottom of handlers.rs, to see if you messed that up... And I think the default mask-argument to the qc-macro is MASK_OUT_X_Y, which is not the mask your op used. (Oh, noticed just now you found it! 🍰 )

[emoon]

:)

[marhel]

We Should probably remove the default mask-argument to qc all together, I've actually stopped using that. Now I just copy the op_handler, and transpose the first and second arguments which is a quick and easy move in sublime text. but if course it would be easier not to have to do that swap at all.

[emoon]

Yeah I think that is a good idea.

[marhel]

It seems that the Scc register cycle issue is fixed in Mame.