Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The terminal does not support '\b' well #705

Closed
vhaudiquet opened this issue Jun 15, 2023 · 3 comments · Fixed by #707
Closed

The terminal does not support '\b' well #705

vhaudiquet opened this issue Jun 15, 2023 · 3 comments · Fixed by #707
Labels
bug Something isn't working needs info More information is needed to resolve the issue

Comments

@vhaudiquet
Copy link

vhaudiquet commented Jun 15, 2023 •
edited
Loading

The integrated terminal doesn't allow to erase, even though another terminal works just fine.

Reproduction steps

Create a container with bash, and launch it. I personally used docker image for ubuntu 18.04. Type something in terminal, and press erase key. You will see ^H instead of the character being erased.

This does not happen when i use my system terminal, kitty, with podman attach <container>.

Environment

  • Pods version: 1.2.1 (compiled by hand, from ArchLinux AUR pods-git package, using rust 1.69)
  • Podman version 4.5.1
  • OS: ArchLinux (linux-zen 6.3.7-zen1-1-zen), with Gnome 44.2 on Wayland
@vhaudiquet vhaudiquet added the bug Something isn't working label Jun 15, 2023
marhkb added a commit that referenced this issue Jun 19, 2023
@marhkb
fix(container-terminal): Change backspace-binding
c8a6074 
Changing this property to the value `ascii-delete` should fix a bug
where pressing backspace would produce `^H` in some cases.

Fixes #705
@marhkb marhkb mentioned this issue Jun 19, 2023
Merged
@marhkb
Copy link
Owner

marhkb commented Jun 19, 2023 •
edited
Loading

Could you try #707? This PR changes the backspace binding of the vte::Terminal which should fix the behavior in the Ubuntu container.
I hope there will be no regressions elsewhere.

@vhaudiquet
Copy link
Author

Thank you ! I will try when i can

@marhkb
Copy link
Owner

marhkb commented Jun 28, 2023

Have you had time to try this?

@marhkb marhkb added the needs info More information is needed to resolve the issue label Jul 8, 2023
marhkb added a commit that referenced this issue Jul 13, 2023
@marhkb
fix(container-terminal): Change backspace-binding
591c0e4 
Changing this property to the value `ascii-delete` should fix a bug
where pressing backspace would produce `^H` in some cases.

Fixes #705
marhkb added a commit that referenced this issue Jul 13, 2023
@marhkb
fix(container-terminal): Change backspace-binding
679de16 
Changing this property to the value `ascii-delete` should fix a bug
where pressing backspace would produce `^H` in some cases.

Fixes #705
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working needs info More information is needed to resolve the issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(container-terminal): Change backspace-binding marhkb/pods
2 participants
@marhkb @vhaudiquet