Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trivial spelling errors #220

Open
wants to merge 1 commit into
base: 3.3
Choose a base branch
from

Conversation

ottok
Copy link
Contributor

@ottok ottok commented Mar 11, 2023

  • handshak -> handshake
  • occured -> occurred
  • releated -> related
  • reponse -> response
  • seperated -> separated
  • sucess -> success
  • use use -> use

@ottok
Copy link
Contributor Author

ottok commented Mar 11, 2023

Travis CI failed on mtr test main.timezone3 and unit test test_conc632 but I don't see exactly why, and git head 3.3 was already broken (https://github.com/mariadb-corporation/mariadb-connector-c/runs/11816127568) so I don't think these spelling fixes broken the CI and this PR should be merged despite failing CI (or I can rebase it on latest git head 3.3 when you have it fixed).

@ottok
Copy link
Contributor Author

ottok commented Mar 26, 2023

Hi! This has been open for two weeks. The topic itself is fairly trivial. Can you please merge or give feedback what changes you wish to see in it?

@ottok
Copy link
Contributor Author

ottok commented Apr 9, 2023

Rebased on latest 3.3.

CI tests are failing on issues that are not due to this PR but already regressed on mainline (missing grants, SQL procedure syntax errors, missing test data file etc).

Merging this PR is safe.

@ottok
Copy link
Contributor Author

ottok commented May 24, 2023

@LinuxJedi Could you please review and merge this? The MariaDB Connector C is embedded in the MariaDB Server which the Foundation publishes.

@LinuxJedi
Copy link

@LinuxJedi Could you please review and merge this? The MariaDB Connector C is embedded in the MariaDB Server which the Foundation publishes.

As this is a MariaDB Corporation project, I do not have sufficient privileges to do so.

@9EOR9
Copy link
Collaborator

9EOR9 commented May 30, 2023

man pages are created from Wiki with pandoc markdown to man converter.
For next C/C version we will create man pages automatically (this feature will require pandoc and option -DWITH_DOCS=ON).
Beside the handshake typo all other typos were already fixed in Wiki.

@dlenski
Copy link
Contributor

dlenski commented Jun 13, 2023

- handshak -> handshake
- occured -> occurred
- releated -> related
- reponse -> response
- seperated -> separated
- sucess -> success
- use use -> use

All new code of the whole pull request, including one or several files
that are either new files or modified ones, are contributed under the
BSD-new license. I am contributing on behalf of my employer Amazon Web
Services, Inc.
@ottok
Copy link
Contributor Author

ottok commented Mar 4, 2024

I rebased this now on latest 3.3. Can you @9EOR9 please merge this?

The fixes are trivial spelling fixes and the PR has been open for a year now. It should not matter if the man pages are copied from elsewhere, this PR still fixes them in the target for now and there is no downside to it.

@illuusio
Copy link

man pages are created from Wiki with pandoc markdown to man converter. For next C/C version we will create man pages automatically (this feature will require pandoc and option -DWITH_DOCS=ON). Beside the handshake typo all other typos were already fixed in Wiki.

Sorry being bit late in party but could man pages regenerated with newer pandoc as it would fix warnings like:

W: libmariadb-dev: groff-message troff:<standard input>:102: warning: cannot select font 'C' [usr/share/man/man3/mariadb_get_infov.3.gz:45]
W: libmariadb-dev: groff-message troff:<standard input>:105: warning: cannot select font 'C' [usr/share/man/man3/mysql_real_connect.3.gz:16]
W: libmariadb-dev: groff-message troff:<standard input>:106: warning: cannot select font 'C' [usr/share/man/man3/mysql_optionsv.3.gz:51]
...

According to this jgm/pandoc#9020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants