[CONJ-1150] adding test case for #190

additionally, keeping StringCodec.INSTANCE in place of Parameter.NULL_PARAMETER for optimization in case of using batch instance (BULK operations send a packet each time parameter datatype change)
mariadb-corporation · Jan 12, 2024 · 5b2a40c · 5b2a40c
1 parent 2f9738f
commit 5b2a40c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/main/java/org/mariadb/jdbc/BasePreparedStatement.java b/src/main/java/org/mariadb/jdbc/BasePreparedStatement.java
@@ -890,11 +890,7 @@ public void setNull(int parameterIndex, int sqlType, String typeName) throws SQL
   @Override
   public void setURL(int parameterIndex, URL x) throws SQLException {
     checkIndex(parameterIndex);
-    if (x == null) {
-      parameters.set(parameterIndex - 1, Parameter.NULL_PARAMETER);
-    } else {
-      parameters.set(parameterIndex - 1, new Parameter<>(StringCodec.INSTANCE, x.toString()));
-    }
+    parameters.set(parameterIndex - 1, new Parameter<>(StringCodec.INSTANCE, x == null ? null : x.toString()));
   }
 
   /**

diff --git a/src/test/java/org/mariadb/jdbc/integration/PreparedStatementParametersTest.java b/src/test/java/org/mariadb/jdbc/integration/PreparedStatementParametersTest.java
@@ -310,6 +310,10 @@ public void checkParameters(org.mariadb.jdbc.Connection con, boolean text) throw
         ps -> ps.setURL(1, new URL("https://www.someUrl.com")),
         rs -> assertEquals("https://www.someUrl.com", rs.getString(1)),
         con);
+    checkSendString(
+            ps -> ps.setURL(1, (URL) null),
+            rs -> assertNull(rs.getString(1)),
+            con);
     // TODO SET OBJECT
   }