[CONJS-173] permitting providing null as a value without an array

lib/cmd/query.js

@@ -22,7 +22,7 @@ class Query extends CommonText {
    * @param info  connection information
    */
   start(out, opts, info) {
-    if (!this.initialValues) {
+    if (this.initialValues === undefined) {
       //shortcut if no parameters
       out.startPacket(this);
       out.writeInt8(0x03);

test/integration/test-pool.js

@@ -108,6 +108,20 @@ describe('Pool', () => {
     pool.end();
   });
 
+  it('query with null placeholder', async function () {
+    const pool = base.createPool({ connectionLimit: 1 });
+    let rows = await pool.query('select ? as a', [null]);
+    assert.deepEqual(rows, [{ a: null }]);
+    await pool.end();
+  });
+
+  it('query with null placeholder no array', async function () {
+    const pool = base.createPool({ connectionLimit: 1 });
+    let rows = await pool.query('select ? as a', null);
+    assert.deepEqual(rows, [{ a: null }]);
+    await pool.end();
+  });
+
   it('pool with wrong authentication', function (done) {
     if (process.env.srv === 'maxscale' || process.env.srv === 'skysql-ha') this.skip(); //to avoid host beeing blocked
     this.timeout(10000);

test/integration/test-query.js

@@ -20,6 +20,16 @@ describe('basic query', () => {
       .catch(done);
   });
 
+  it('query with null placeholder', async function () {
+    let rows = await shareConn.query('select ? as a', [null]);
+    assert.deepEqual(rows, [{ a: null }]);
+  });
+
+  it('query with null placeholder no array', async function () {
+    let rows = await shareConn.query('select ? as a', null);
+    assert.deepEqual(rows, [{ a: null }]);
+  });
+
   it('parameter last', async () => {
     const value = "'`\\";
     const conn = await base.createConnection();