You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It would be great to have the same colorbar/colorscale for the contour plots that are generated with img_gen=True. I think this would involve pre-setting a vmin and vmax to add to the plt.imshow() calls in the code below. The tricky bit would be determining those numbers which could vary depending on the run. It is nice to let the plotting code determine them for you, but then you lose consistency.
Thanks @katiedagon! Good idea! Based on discussion today, we can keep this as maybe lower priority to do item, to keep debugging / evaluation of output more modular, but I agree that it would be good to add an option for this as we are in the more final stages of training and saving models. Or maybe making this a hyper yaml file option that could be turned "on" or "off" could work to keep things more flexible when needed.
Sounds like a good plan @mariajmolina, thanks for clarifying that you already thought this through and in particular there are considerations that make setting a vmin and vmax tricky.
It would be great to have the same colorbar/colorscale for the contour plots that are generated with
img_gen=True
. I think this would involve pre-setting avmin
andvmax
to add to theplt.imshow()
calls in the code below. The tricky bit would be determining those numbers which could vary depending on the run. It is nice to let the plotting code determine them for you, but then you lose consistency.s2sml/applications/train.py
Lines 186 to 219 in f046727
I am happy to help work on this, adding an issue here to keep others in the loop.
The text was updated successfully, but these errors were encountered: