Fixed fp16 training/inference with factors-combine concat (#926)

marian-nmt · Mar 22, 2022 · 23c36ec · 23c36ec
1 parent 78bef7a
commit 23c36ec
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -13,6 +13,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 ### Fixed
 - Scripts using PyYAML now use `safe_load`; see https://msg.pyyaml.org/load
 - Fixed check for `fortran_ordering` in cnpy
+- Fixed fp16 training/inference with factors-combine concat method
 
 ### Changed
 - Make guided-alignment faster via sparse memory layout, add alignment points for EOS, remove losses other than ce

diff --git a/src/layers/embedding.cpp b/src/layers/embedding.cpp
@@ -57,8 +57,7 @@ Embedding::Embedding(Ptr<ExpressionGraph> graph, Ptr<Options> options)
   auto lemmaEmbs = rows(E_, lemmaIndices);
   int dimFactors = FactorEmbMatrix_->shape()[0];
   auto factEmbs
-      = dot(graph->constant(
-                {(int)data.size(), dimFactors}, inits::fromVector(factorIndices), Type::float32),
+      = dot(graph->constant({(int)data.size(), dimFactors}, inits::fromVector(factorIndices)),
             FactorEmbMatrix_);
 
   return concatenate({lemmaEmbs, factEmbs}, -1);