style(build_namespace_name): fix Rubocop issue

marian13 · Jun 13, 2023 · 73e10db · 73e10db
1 parent dbf79fd
commit 73e10db
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 8 deletions.
diff --git a/lib/convenient_service/support/dependency_container/commands/fetch_namespace.rb b/lib/convenient_service/support/dependency_container/commands/fetch_namespace.rb
@@ -48,7 +48,7 @@ def call
           # @return [Symbol]
           #
           def namespace_name
-            Commands::BuildNamespaceName.call(scope: scope, prepend: prepend)
+            @namespace_name ||= Commands::BuildNamespaceName.call(scope: scope, prepend: prepend)
           end
         end
       end

diff --git a/lib/convenient_service/support/dependency_container/commands/get_namespace.rb b/lib/convenient_service/support/dependency_container/commands/get_namespace.rb
@@ -48,7 +48,7 @@ def call
           # @return [Symbol]
           #
           def namespace_name
-            Commands::BuildNamespaceName.call(scope: scope, prepend: prepend)
+            @namespace_name ||= Commands::BuildNamespaceName.call(scope: scope, prepend: prepend)
           end
         end
       end

diff --git a/...lib/convenient_service/support/dependency_container/commands/build_namespace_name_spec.rb b/...lib/convenient_service/support/dependency_container/commands/build_namespace_name_spec.rb
@@ -4,6 +4,7 @@
 
 require "convenient_service"
 
+# rubocop:disable RSpec/NestedGroups
 RSpec.describe ConvenientService::Support::DependencyContainer::Commands::BuildNamespaceName do
   example_group "class methods" do
     describe ".call" do
@@ -16,15 +17,15 @@
         context "when `scope` is valid" do
           context "when `scope` is `:class`" do
             it "returns valid namespace name" do
-              expect(command_result).to eq(:"ImportedIncludedClassMethods")
+              expect(command_result).to eq(:ImportedIncludedClassMethods)
             end
           end
 
           context "when `scope` is `:instance`" do
             let(:scope) { :instance }
 
             it "returns valid namespace name" do
-              expect(command_result).to eq(:"ImportedIncludedInstanceMethods")
+              expect(command_result).to eq(:ImportedIncludedInstanceMethods)
             end
           end
         end
@@ -33,7 +34,7 @@
           let(:scope) { nil }
 
           it "returns namespace name without `scope` value" do
-            expect(command_result).to eq(:"ImportedIncludedMethods")
+            expect(command_result).to eq(:ImportedIncludedMethods)
           end
         end
       end
@@ -42,15 +43,15 @@
         context "when `prepend` is valid" do
           context "when `prepend` is `false`" do
             it "returns valid namespace name" do
-              expect(command_result).to eq(:"ImportedIncludedClassMethods")
+              expect(command_result).to eq(:ImportedIncludedClassMethods)
             end
           end
 
           context "when `prepend` is `true`" do
             let(:prepend) { true }
 
             it "returns valid namespace name" do
-              expect(command_result).to eq(:"ImportedPrependedClassMethods")
+              expect(command_result).to eq(:ImportedPrependedClassMethods)
             end
           end
         end
@@ -59,10 +60,11 @@
           let(:prepend) { nil }
 
           it "behaves like `include`" do
-            expect(command_result).to eq(:"ImportedIncludedClassMethods")
+            expect(command_result).to eq(:ImportedIncludedClassMethods)
           end
         end
       end
     end
   end
 end
+# rubocop:enable RSpec/NestedGroups
diff --git a/spec/lib/convenient_service/support/dependency_container/commands/fetch_namespace_spec.rb b/spec/lib/convenient_service/support/dependency_container/commands/fetch_namespace_spec.rb
@@ -4,6 +4,7 @@
 
 require "convenient_service"
 
+# rubocop:disable RSpec/NestedGroups
 RSpec.describe ConvenientService::Support::DependencyContainer::Commands::FetchNamespace do
   example_group "class methods" do
     describe ".call" do
@@ -54,3 +55,4 @@
     end
   end
 end
+# rubocop:enable RSpec/NestedGroups
diff --git a/spec/lib/convenient_service/support/dependency_container/commands/get_namespace_spec.rb b/spec/lib/convenient_service/support/dependency_container/commands/get_namespace_spec.rb
@@ -4,6 +4,7 @@
 
 require "convenient_service"
 
+# rubocop:disable RSpec/NestedGroups
 RSpec.describe ConvenientService::Support::DependencyContainer::Commands::GetNamespace do
   example_group "class methods" do
     describe ".call" do
@@ -50,3 +51,4 @@
     end
   end
 end
+# rubocop:enable RSpec/NestedGroups