Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CS-1: Fix Module#include incompatibility #3

Merged
merged 13 commits into from
Oct 6, 2022

Conversation

marian13
Copy link
Owner

@marian13 marian13 commented Oct 6, 2022

What was done as part of this PR?

  • Implemented a hack that makes Module#include behavior compatible between Ruby 2.7 and Ruby 3.0+.

How to test?

Notes

@marian13 marian13 changed the title CS-1: Fix include incompatibility CS-1: Fix Module#include incompatibility Oct 6, 2022
@marian13 marian13 self-assigned this Oct 6, 2022
@coveralls
Copy link

coveralls commented Oct 6, 2022

Pull Request Test Coverage Report for Build 3199355194

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 191 of 191 (100.0%) changed or added relevant lines in 24 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 94.658%

Totals Coverage Status
Change from base Build 3166557777: 0.2%
Covered Lines: 4997
Relevant Lines: 5279

💛 - Coveralls

@marian13 marian13 merged commit 0aa2d9d into main Oct 6, 2022
@marian13 marian13 deleted the CS-1_fix_include_incompatibility branch October 6, 2022 18:19
@marian13 marian13 added the fix Fix was the initial reason of the PR. From Conventional Commits. label Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fix was the initial reason of the PR. From Conventional Commits.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants