Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CS-19: stub_service without RSpec mocks #31

Merged
merged 15 commits into from
Dec 17, 2022

Conversation

marian13
Copy link
Owner

@marian13 marian13 commented Dec 11, 2022

What was done as a part of this PR?

  • Created CanHaveStubbedResult plugin.
  • Reimplemented stub_service without RSpec mocks.

Why it was done?

How it was done?

How to test?

Open Questions?

  • Ability to extend Standard config outside configs/standard.rb file.

Checklist:

  • I have performed a self-review of my code.
  • I have added/adjusted tests that prove my fix is effective or that my feature works.
  • CI is green.

@marian13 marian13 added the refactor Refactoring was the initial reason of the PR. From Conventional Commits. label Dec 11, 2022
@marian13 marian13 self-assigned this Dec 11, 2022
@coveralls
Copy link

coveralls commented Dec 11, 2022

Pull Request Test Coverage Report for Build 3721308502

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 85 of 85 (100.0%) changed or added relevant lines in 11 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 96.514%

Totals Coverage Status
Change from base Build 3721269925: 0.3%
Covered Lines: 5731
Relevant Lines: 5938

💛 - Coveralls

@marian13
Copy link
Owner Author

Screenshot 2022-12-16 at 21 58 28

@marian13 marian13 force-pushed the CS-19_reimplement_stub_service_via_plugin branch from c956643 to 99f2553 Compare December 16, 2022 22:12
@marian13 marian13 merged commit 766eb5a into main Dec 17, 2022
@marian13 marian13 deleted the CS-19_reimplement_stub_service_via_plugin branch December 17, 2022 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactoring was the initial reason of the PR. From Conventional Commits.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants