Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test case testDistance fails #3

Open
ralmeida opened this issue May 13, 2011 · 3 comments
Open

Test case testDistance fails #3

ralmeida opened this issue May 13, 2011 · 3 comments

Comments

@ralmeida
Copy link

I downloaded your plugin today, and ran the tests, at 1st I did not have my API key in, but once in the "testDistance" was not passing.

tests/cases/behaviors/geocodable.test.php -> GeocodableBehaviorTest -> testDistance

Equal expectation fails because [Float: 9] differs from [Float: 3.4] by 5.6

Is this an error or a bad test case?

Thanks,
Ron

@mescalito
Copy link

I'm getting exactly the same:

Equal expectation fails with member [1] because [Float: -82.4736] differs from [Float: -82.4735] by 0.00010000000000332 at [C:\wamp\www\Users\app\plugins\geocode\tests\cases\behaviors\geocodable.test.php line 144]
C:\wamp\www\Users\app\plugins\geocode\tests\cases\behaviors\geocodable.test.php -> GeocodableBehaviorTest -> testGeocodeNoApiKey

How did u fixed it Ron-Ralmeida?

Thanks!

@ralmeida
Copy link
Author

I did not even mess with it again, was more making them aware of the issue

@real34
Copy link

real34 commented Dec 14, 2011

It seems that the testDistance test expectation was incorrect. We investigated and ended up modifying it.
A pull request for this (with further details) is available (see #5)

mariano added a commit that referenced this issue Dec 14, 2011
Fixes issue #3 (testDistance fail because 9 != 3.4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants