Check for DBUS Notifications service presence #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of checking for the presence of particular environment variables, set by Desktop Environments, we should check if there is any service on DBus that listens to org.freedesktop.Notifications. This is important for people who use different services that provide notification features like Dunst[1]. See [2] to check a more detailed list. 1: https://github.com/knopwob/dunst 2: https://wiki.archlinux.org/index.php/Desktop_Notifications
mariano
added a commit
that referenced
this pull request
May 7, 2014
Check for DBUS Notifications service presence
|
Thanks @mariano, just tested and it works! There are only two concerns now, if we should include the |
|
Other places such as? I have tons of ideas for the next release, but not timeframe set, as usual On Wed, May 7, 2014 at 11:30 AM, Amadeus Folego notifications@github.comwrote:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of checking for the presence of particular environment
variables, set by Desktop Environments, we should check if there is
any service on DBus that listens to org.freedesktop.Notifications.
This is important for people who use different services that provide
notification features like Dunst.
See this link for a more detailed list.