Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor data structures #68

Merged
merged 3 commits into from
Oct 29, 2017
Merged

Refactor data structures #68

merged 3 commits into from
Oct 29, 2017

Conversation

pdhoopr
Copy link
Collaborator

@pdhoopr pdhoopr commented Oct 22, 2017 •
edited

This PR basically just refactors how some of the data stored in Firebase is named and structured once it's in the app:

  • Don't save entity ID attributes as part of the data in Firebase since the Firebase key is already the ID
  • Add the entity IDs back when loading into app state
  • Rename a user's uid attribute to just id
  • Replace the user ID stored under a challenge's contributor attribute and a submission's author attribute with the actual data corresponding to that user ID

Helps with #34.

mariehooper
mariehooper approved these changes Oct 29, 2017
View reviewed changes
Copy link
Owner

@mariehooper mariehooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@pdhoopr pdhoopr merged commit 939d84f into master Oct 29, 2017
@pdhoopr pdhoopr deleted the refactor-data-structures branch October 29, 2017 13:18
@mariehooper mariehooper mentioned this pull request Nov 11, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariehooper mariehooper mariehooper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pdhoopr @mariehooper