Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DST-363]: Adding Guideline-Page of how to use Multiselection #3824

Merged
merged 41 commits into from
Mar 19, 2024

Conversation

OsamaAbdellateef
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Mar 13, 2024

🦋 Changeset detected

Latest commit: 45b1d30

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@marigold/components Patch
@marigold/docs Patch
@marigold/storybook-config Patch
@marigold/theme-b2b Patch
@marigold/theme-core Patch
@marigold/system Patch
@marigold/icons Patch
@marigold/theme-preset Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Mar 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marigold-docs ✅ Ready (Inspect) Visit Preview 6 resolved Mar 19, 2024 10:29am
marigold-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2024 10:29am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
marigold-production ⬜️ Ignored (Inspect) Visit Preview Mar 19, 2024 10:29am

@github-actions github-actions bot added the type:docs Improvements or additions to documentation label Mar 13, 2024
@OsamaAbdellateef
Copy link
Contributor Author

now test is fixed @sebald

sebald
sebald previously approved these changes Mar 18, 2024
Copy link
Member

@sebald sebald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OsamaAbdellateef is this now the only PR to merge?

E.g. this includes the recipe and guide?

packages/components/src/TagGroup/Tag.tsx Outdated Show resolved Hide resolved
packages/components/src/index.ts Show resolved Hide resolved
@OsamaAbdellateef
Copy link
Contributor Author

@OsamaAbdellateef is this now the only PR to merge?

E.g. this includes the recipe and guide?

Yeah it includes both @sebald

sebald
sebald previously approved these changes Mar 19, 2024
@sebald sebald merged commit 879a0e1 into main Mar 19, 2024
12 checks passed
@sebald sebald deleted the multiselect-guideline branch March 19, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:docs Improvements or additions to documentation type:feature New feature or component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants