Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refa[DSTSUP-73]: Improve elevation (more distinguisable) #3889

Merged
merged 6 commits into from
May 13, 2024
Merged

refa[DSTSUP-73]: Improve elevation (more distinguisable) #3889

merged 6 commits into from
May 13, 2024

Conversation

sebald
Copy link
Member

@sebald sebald commented Apr 29, 2024

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 29, 2024 •
edited

🦋 Changeset detected

Latest commit: 1662770

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@marigold/theme-b2b Patch
@marigold/storybook-config Patch
@marigold/docs Patch
@marigold/system Patch
@marigold/components Patch
@marigold/icons Patch
@marigold/theme-preset Patch
@marigold/theme-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Apr 29, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marigold-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 2:35pm
marigold-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 2:35pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
marigold-production ⬜️ Ignored (Inspect) Visit Preview May 13, 2024 2:35pm

@github-actions github-actions bot added the type:feature New feature or component label Apr 29, 2024
@sebald sebald marked this pull request as draft April 29, 2024 09:59
@sebald
Copy link
Member Author

sebald commented Apr 29, 2024

Note

Waiting for feedback from our designers.

Also: I would move the input styles that are also shared to the mixins file afer this gets merged.

@sebald sebald marked this pull request as ready for review April 29, 2024 13:56
@sarahgm
Copy link
Member

sarahgm commented Apr 30, 2024

I think than needs to be also updated the elevation documentation

@sarahgm sarahgm changed the title refa(DSTSUP-73): Improve elevation (more distinguisable) refa[DSTSUP-73]: Improve elevation (more distinguisable) Apr 30, 2024
@sebald sebald marked this pull request as draft April 30, 2024 08:29
@github-actions github-actions bot added the type:docs Improvements or additions to documentation label Apr 30, 2024
@sebald
Copy link
Member Author

sebald commented Apr 30, 2024

@KadaStrophe can you send us an updated image (elevation page)

@sebald sebald marked this pull request as ready for review May 7, 2024 08:17
@sarahgm sarahgm merged commit f0c0bc1 into main May 13, 2024
12 checks passed
@sarahgm sarahgm deleted the adjust-elevation branch May 13, 2024 14:41
@github-actions github-actions bot mentioned this pull request May 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aromko aromko aromko left review comments

@sarahgm sarahgm sarahgm approved these changes

Assignees
No one assigned
Labels
type:docs Improvements or additions to documentation type:feature New feature or component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sebald @sarahgm @aromko