chore: remove story wrapper and add prop for demos

[sarahgm]

No description provided.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
marigold-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 14, 2024 2:29pm
marigold-storybook	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 14, 2024 2:29pm

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
marigold-production	⬜️ Ignored (Inspect)	Visit Preview		Jun 14, 2024 2:29pm

[changeset-bot]

⚠️ No Changeset found

Latest commit: b43f302

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[aromko]

Is there some context what and why we are doing these changes?

[sarahgm]

Is there some context what and why we are doing these changes?

@aromko Yes you can go to our docs and storybook, then you will see that the Table Checkboxes are aligend with form fields. There are no because its a table but around the demo there is the <FieldGroup> which sets the labelwidth to 100px, and because of that the Checkbox also sets the labelWidth.

For Storybook i tried to solve it through parameteres and addons but they are not allowing custom stuff there, so I removed the wrapper and add the <FieldGroup> to all Form Fields manuel

[aromko]

Is there some context what and why we are doing these changes?

@aromko Yes you can go to our docs and storybook, then you will see that the Table Checkboxes are aligend with form fields. There are no because its a table but around the demo there is the <FieldGroup> which sets the labelwidth to 100px, and because of that the Checkbox also sets the labelWidth.

For Storybook i tried to solve it through parameteres and addons but they are not allowing custom stuff there, so I removed the wrapper and add the <FieldGroup> to all Form Fields manuel

💡 thanks

[sebald]

@sarahgm I would take over so we can move this forward. Can you give me what needs to be done here tomorrow? :D

[sebald]

Honest question 🙈 We now have a "positive implementation" (fieldGroup: true) and a "negative one" (disableLabelWidth: true). I think we should settle on one, otherwhise this will get very confusing for ust.

[sarahgm]

Honest question 🙈 We now have a "positive implementation" (fieldGroup: true) and a "negative one" (disableLabelWidth: true). I think we should settle on one, otherwhise this will get very confusing for ust.

There would be the thing than that you have to set to every demo fieldGroup: true to every demo that has a fieldgroup. For me I thought it easier to just disable the fieldGroup for the table.
Same for the storybook preview, there I found it easier to just say these components should have a fieldGroup:true.

And to not forget, I would add this information to our Component Developing Guidelines :)

And if you still don't like it, maybe I can use the same disableLabelWidth: true just in the table story?

@OsamaAbdellateef @sebald what do you think about this?

[sebald]

Honest question 🙈 We now have a "positive implementation" (fieldGroup: true) and a "negative one" (disableLabelWidth: true). I think we should settle on one, otherwhise this will get very confusing for ust.

There would be the thing than that you have to set to every demo fieldGroup: true to every demo that has a fieldgroup. For me I thought it easier to just disable the fieldGroup for the table. Same for the storybook preview, there I found it easier to just say these components should have a fieldGroup:true.

And to not forget, I would add this information to our Component Developing Guidelines :)

And if you still don't like it, maybe I can use the same disableLabelWidth: true just in the table story?

@OsamaAbdellateef @sebald what do you think about this?

Yes, disabling it would also be fine. I just don't like to have different options for the same thing :D