Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(DST-404): Introduce Grid component #3913

Merged
merged 16 commits into from
May 24, 2024
Merged

feat(DST-404): Introduce Grid component #3913

merged 16 commits into from
May 24, 2024

Conversation

sebald
Copy link
Member

@sebald sebald commented May 14, 2024

No description provided.

@vercel Vercel
Copy link

vercel bot commented May 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marigold-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2024 1:25pm
marigold-storybook ✅ Ready (Inspect) Visit Preview ✅ 1 resolved May 24, 2024 1:25pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
marigold-production ⬜️ Ignored (Inspect) Visit Preview 💬 Add feedback May 24, 2024 1:25pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 14, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 7df2d01

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@marigold/docs Minor
@marigold/components Minor
@marigold/system Minor
@marigold/storybook-config Patch
@marigold/theme-b2b Patch
@marigold/theme-core Patch
@marigold/icons Patch
@marigold/theme-preset Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added type:docs Improvements or additions to documentation type:feature New feature or component labels May 14, 2024
@sebald
Copy link
Member Author

sebald commented May 14, 2024

@marigold-ui/developer not sure if the name is great since it is not a full CSS grid

@sebald sebald changed the title feat: Introduce Template component feat: Introduce Grid component May 14, 2024
@sebald sebald changed the title feat: Introduce Grid component feat(DST-404): Introduce Grid component May 14, 2024
aromko
aromko reviewed May 15, 2024
View reviewed changes
docs/content/components/layout/grid/grid.mdx Outdated Show resolved Hide resolved
packages/components/src/Grid/Grid.tsx Outdated Show resolved Hide resolved
aromko
aromko previously approved these changes May 22, 2024
View reviewed changes
docs/content/components/layout/grid/grid.mdx Outdated Show resolved Hide resolved
docs/content/components/layout/grid/grid-bento.demo.tsx Show resolved Hide resolved
packages/components/src/Grid/Grid.tsx Outdated Show resolved Hide resolved
@sebald
Copy link
Member Author

sebald commented May 23, 2024

@marcelkoehler renamed it to Grid.Area this seems more logical than slot to me. good idea?

aromko
aromko previously approved these changes May 24, 2024
View reviewed changes
@aromko aromko merged commit 8c4631f into main May 24, 2024
12 checks passed
@aromko aromko deleted the layout-component-grid branch May 24, 2024 13:27
@github-actions github-actions bot mentioned this pull request May 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aromko aromko aromko approved these changes

Assignees
No one assigned
Labels
type:docs Improvements or additions to documentation type:feature New feature or component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sebald @aromko