Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DST-407]: enhance command menu #3920

Open
wants to merge 84 commits into
base: main
Choose a base branch
from
Open

[DST-407]: enhance command menu #3920

wants to merge 84 commits into from

Conversation

sarahgm
Copy link
Member

@sarahgm sarahgm commented May 24, 2024

  • added keywords to search (e.g. search: help -> support bord and slack displayed, search: copy -> available copy objects displayed
  • fixed search
  • added links, tokens and theme switch option
  • copy icons & tokens
  • added subpages when pressing a chosen page

Copy link

vercel bot commented May 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marigold-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2024 8:51am
marigold-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2024 8:51am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
marigold-production ⬜️ Ignored (Inspect) Visit Preview Jun 20, 2024 8:51am

Copy link

changeset-bot bot commented May 24, 2024

🦋 Changeset detected

Latest commit: 97c466a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@marigold/docs Patch
@marigold/system Patch
@marigold/components Patch
@marigold/icons Patch
@marigold/theme-preset Patch
@marigold/theme-b2b Patch
@marigold/theme-core Patch
@marigold/theme-docs Patch
@marigold/storybook-config Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

@tirado-rx tirado-rx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wording recommendations

-"Action"–>"Go"
-"More details"–>"Show sublevels" or "Show subcategories"

Copy link

@tirado-rx tirado-rx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After thinking about it some more: I would recommend changing "Show sublevels" to "Expand".

Its action is more specific and will likely be easier to visualize for users. But without testing we won't know anything for sure. At some point, we'll need to incorporate that into our documentation design process.

Captura de pantalla 2024-06-20 a la(s) 10 24 20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:docs Improvements or additions to documentation type:feature New feature or component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants