Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DST-387]: Generate property tables in our documentation from code #3923

Merged
merged 26 commits into from
Jun 7, 2024
Merged

[DST-387]: Generate property tables in our documentation from code #3923

merged 26 commits into from
Jun 7, 2024

Conversation

OsamaAbdellateef
Copy link
Contributor

Making the props dynamic based on the the types inside the component

@vercel Vercel
Copy link

vercel bot commented May 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marigold-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2024 8:17am
marigold-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2024 8:17am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
marigold-production ⬜️ Ignored (Inspect) Visit Preview Jun 7, 2024 8:17am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 28, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: bc4e161

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@OsamaAbdellateef OsamaAbdellateef changed the title Docs: Generate property tables in our documentation from code [DST-387]: Generate property tables in our documentation from code May 28, 2024
sebald
sebald requested changes Jun 5, 2024
View reviewed changes
docs/scripts/build-props-table.mjs Outdated Show resolved Hide resolved
docs/scripts/build-props-table.mjs Outdated Show resolved Hide resolved
docs/scripts/build-props-table.mjs Outdated Show resolved Hide resolved
sebald
sebald requested changes Jun 5, 2024
View reviewed changes
docs/package.json Outdated Show resolved Hide resolved
docs/scripts/build-component-props.mjs Outdated Show resolved Hide resolved
docs/scripts/build-component-props.mjs Outdated Show resolved Hide resolved
@sebald
Copy link
Member

sebald commented Jun 5, 2024

Sorry, some small adjustments 🙈

@OsamaAbdellateef
Copy link
Contributor Author

Sorry, some small adjustments 🙈

It's fine i leaned a lot

@sebald sebald merged commit ab6ba78 into main Jun 7, 2024
12 checks passed
@sebald sebald deleted the generate-props-table branch June 7, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebald sebald sebald approved these changes

Assignees
No one assigned
Labels
type:docs Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@OsamaAbdellateef @sebald