Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove comma separator from 'render_html.js' script and insert it in using CSS #457

Closed
wants to merge 1 commit into from

Conversation

mahdavipanah
Copy link

Not all languages use , character as the comma.
So it's better to insert the comma separator between author's name and its citation's title (in quote blocks) using CSS tricks so, in order to change the comma character in the translation process, there is no need to change the render_html.js script and only the stylesheets.

@marijnh
Copy link
Owner

marijnh commented Oct 19, 2018

I'm a bit concerned about that not being copy-pasteable (the same goes for the quotes, I'm aware, but missing those is less disruptive than having author and source mashed together without any kind of separator).

How about we do a thing where there's a separate configuration .js file that specifies things like this, and the renderer takes the separator from there?

@mahdavipanah
Copy link
Author

It's a very good idea.
Or even it can be configurable using a specific template. For example, the whole author and it's source is defined like this as default:

const configs = {
  authorSourceOfQuote: '{author}, {source}',
}

and then for translation it can very straight forward to change it:

const configs = {
  authorSourceOfQuote: '{source} ،{author}',
}

@marijnh
Copy link
Owner

marijnh commented Oct 19, 2018

Right. There's already a templating lib (mold) included, so you could build it on top of that.

@mahdavipanah
Copy link
Author

I'll try and do my best. Since the translation is a gradual process, I think it would be better to try and generalize needed parts as I go through the process.

Thanks.

@mahdavipanah mahdavipanah deleted the quote-block-patch branch October 19, 2018 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants