Add ESM support #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marijnh Please let me know what you think. |
|
Thanks, works for me (though I'd have gone from an ES6 source file to a cjs output file). Published as 1.1.0. |
|
Great, thanks (even if the code base is small, I use to write code in TypeScript and Java, so generating the ESM version was less error-prone and saved some time). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the first PR we discussed.
The idea is to not touch the existing code but to generate the ESM version using rollup. The generated ESM version is included in the NPM package before releasing it. The
modulefield is added to package.json for automatic detection by common tools.