Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds option to use ST 3 new tooltips #61

Closed
wants to merge 4 commits into from
Closed

Conversation

subhaze
Copy link
Contributor

@subhaze subhaze commented Feb 17, 2015

Adds tooltip support for ST 3, if a URL or doc is available, it shows that as well.

As of right now this will only work on the very latest ST 3 dev build (3070)

screenshot 2015-02-17 11 33 38

screenshot 2015-02-17 11 33 58

@marijnh
Copy link
Member

marijnh commented Feb 17, 2015

Can we feature-detect tooltip support by checking whether show_popup exists in view, and make that the default if supported?

@subhaze
Copy link
Contributor Author

subhaze commented Feb 17, 2015

@marijnh Sure, I'll update the patch in a bit.

@lukasbob
Copy link

Played around with this and it looks great! Might need better handling of long URLs, though. These cause the content to expand so it overflows the 600px width of the tooltip, obscuring some of the content. The screenshot below shows this:

image

marijnh added a commit that referenced this pull request Feb 18, 2015
@marijnh
Copy link
Member

marijnh commented Feb 18, 2015

I wasn't able to test this myself yet, since I don't have a Sublime Text key, but the code looks good, and I've merged it. I made a small change in 1afc929. Please verify that that also works on ST3.

@subhaze
Copy link
Contributor Author

subhaze commented Feb 18, 2015

@lukasbob OS X has the ability to scroll to the overflow, however, I've seen reports to the ST developer where it's not possible on other platforms. Future updates to ST 3 should resolve this.

@marijnh I've added a comment to that code change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants