Read CSLA config values from .NET Core config subsystem

[rockfordlhotka]

CSLA should have its own configuration section in appsettings.json file for this and further configurations.

Example (just a few of them):

{
   "csla": {
      "proxyType":"name",
      "authentication":"windows",
      "serializationFormatter":"MobileFormatter"
    }
}

Beside fluent interface, existing configuration mechanism implemented in .NET Core can be used to read from appsettings.json and other sources supported by .NET Core.

[rockfordlhotka]

My understanding is that the .NET Core config subsystem takes the names of your settings (like you have in the json @itgoran) and flattens them for use in ENV variables or other scenarios. I don't know the exact algorithm, but something like csla-proxyType I think.

They use a precedence scheme (I don't remember the specifics) so they'll read the value from the config file, ENV variables, and maybe other sources, and there are rules as to which values ultimately "win" - which overrides the others.

In the end, the code throughout CSLA itself uses ConfigurationManager.AppSettings to access all the values, using hard-coded config value names.

So it seems to me that what we need to do is load the values from the .NET Core config subsystem, then map those values into the pre-defined AppSettings dictionary for use by all the existing code.

That doesn't seem too difficult.

[rockfordlhotka]

I assembled a list of the settings keys:

CslaAuthentication
CslaAuthorizationProvider
CslaAutoCloneOnUpdate
CslaDataPortalActivator
CslaDataPortalExceptionInspector
CslaDataPortalInterceptor
CslaDataPortalProxy
CslaDataPortalProxyFactory
CslaDataPortalReturnObjectOnException
CslaDataPortalUrl
CslaDefaultTransactionIsolationLevel
CslaDefaultTransactionTimeoutInSeconds
CslaIsInRoleProvider
CslaMobileFactoryLoader
CslaObjectFactoryLoader
CslaPrincipalCacheSize
CslaPropertyChangedMode
CslaPropertyInfoFactory
CslaReader
CslaSerializationFormatter
CslaWriter
dbProvider

The new fluent types in Csla.Configuration should provide a guide to the hierarchy we'd want to use in the json. This is also a good opportunity to have someone (@itgoran) really review the choices I made in how I grouped things in the fluent API - so if I put something in an odd place we can discuss where it should belong.

[itgoran]

Great @rockfordlhotka , I was doing exactly the same thing.
Do you agree with the idea to use json like syntax, without CSLA prefix, since it will be in csla section?
Example:
1.

"csla": {
    "Authentication":"windows",
    "AuthorizationProvider":"...",
    "AutoCloneOnUpdate":"..."
}

or
2. we should proceed with the same key names under "csla" section?

[rockfordlhotka]

I like it without the CSLA prefix - much cleaner.

Also, if we sub-group things like in the fluent API then (excuse my poor json):

"csla": {
     "dataportal": {
          "AutoCloneOnUpdate":"..."
      },
    "Authentication":"windows",
    "AuthorizationProvider":"...",
}

Is that possible?

[itgoran]

Yes, it is.

Also, additional 'grouping' for 'PropertyChanged' and 'DefaultTransaction' can be performed.

1. Should we do this?

"csla": {
   "DefaultTransaction": {
        "IsolationLevel":"..."
        "TimeoutInSeconds":"..."
    },
    "Property": {
      "ChangedMode":"..",
      "InfoFactory":"..."
    }
}

2. Additionally, where a limited set of values can be applied (such as SerializationFormatter), should we log a warning and use the default value?

[rockfordlhotka]

Again, I'd like the fluent API and this json model to line up. Right now I've broken the fluent API into fairly coarse groups

https://github.com/MarimerLLC/csla/tree/master/Source/Csla.Shared/Configuration

The groups are based on the subsystem of CSLA that uses/needs the config setting value.

[rockfordlhotka]

Additionally, where a limited set of values can be applied (such as SerializationFormatter), should we log a warning and use the default value?

This is a good idea, though unfortunately some of the config values are overloaded in their meaning.

For example, CslaSerializationFormatter can be one of:

• BinaryFormatter
• MobileFormatter
• NetDataContractSerializer
• MyProject.MyFormatter, MyProject (assembly qualified type name)

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.