You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Having implemented the basic fluent config API functionality, and on further review, I think it would be a far simpler and better implementation to have the fluent config methods load values into the Csla.Configuration.ConfigurationManager.AppSettings dictionary.
The current implementation sometimes does that, and sometimes sets values directly on the ApplicationContext or other types within the CSLA object model.
Not only is that inconsistent, but I think it adds ambiguity to the behavior. It isn't clear that the fluent API overwrites/overrides config file values (it should). I strongly suspect that, over time, I'd come to regret having this weird dual model for setting config values at runtime.
Add to that, the work item to load values from the .NET Core config subsystem (#967), which also needs a way to map a new config system into the existing config model, and things could get unbearably complex.
If I change the fluent API to load AppSettings, and the .NET Core config approach also loads AppSettings, then we have a unified and consistent scheme for loading config values as the app starts up, regardless of which of the three config models is used.
The text was updated successfully, but these errors were encountered:
Having implemented the basic fluent config API functionality, and on further review, I think it would be a far simpler and better implementation to have the fluent config methods load values into the
Csla.Configuration.ConfigurationManager.AppSettings
dictionary.The current implementation sometimes does that, and sometimes sets values directly on the
ApplicationContext
or other types within the CSLA object model.Not only is that inconsistent, but I think it adds ambiguity to the behavior. It isn't clear that the fluent API overwrites/overrides config file values (it should). I strongly suspect that, over time, I'd come to regret having this weird dual model for setting config values at runtime.
Add to that, the work item to load values from the .NET Core config subsystem (#967), which also needs a way to map a new config system into the existing config model, and things could get unbearably complex.
If I change the fluent API to load AppSettings, and the .NET Core config approach also loads AppSettings, then we have a unified and consistent scheme for loading config values as the app starts up, regardless of which of the three config models is used.
The text was updated successfully, but these errors were encountered: