improvement: click hourglass to move view to current cell #1040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fuenfundachtzig
force-pushed
the
feature/jump-to-running-cell
branch
from
5ae04fa
to
f2df778
Compare
fuenfundachtzig
force-pushed
the
feature/jump-to-running-cell
branch
from
f2df778
to
50d787f
Compare
mscolnick
reviewed
Apr 1, 2024
| const { cellIds } = store.get(notebookAtom); | ||
| const cellIdx = Object.values(state.cellRuntime).findIndex( | ||
| (cell) => cell.status === "running", | ||
| ); |
There was a problem hiding this comment.
i think you can avoid wiring the state through, and might be able to change this to:
const { cellRuntime } = store.get(notebookAtom);
const cell = Objects.entries(cellRuntime).find(
([cellId, runtime]) => runtime.status === "running",
)
if (!cell) {
return;
}
const view = getCellEditorView(cell[0]);
view?.dispatch({
selection: { anchor: 0 },
effects: [EditorView.scrollIntoView(0, { y: "center" })],
});There was a problem hiding this comment.
Looks good, thanks for the suggestion :) I'll give it a try.
There was a problem hiding this comment.
I updated the PR to your suggestion. Thanks for the improvement :)
mscolnick
changed the title
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.3.9-dev7 |
Benni-Math
pushed a commit
to Benni-Math/marimo
that referenced
this pull request
Apr 16, 2024
…m#1040) * click hourglass to move view to current cell * removed dependence on NotebookState as per review comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1030