-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Persist App state + Cell state in md conversions #1326
Persist App state + Cell state in md conversions #1326
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Oh woops. I didn't realize |
|
||
# Native to python | ||
from xml.etree.ElementTree import Element, SubElement | ||
|
||
# Note: yaml is also a python builtin | ||
import yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i might have lazy imported this, just fyi, if you are not up-to-date with main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think in exporter, not here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh thats right
```{.python.marimo unparsable="true"} | ||
it's an unparsable cell | ||
``` | ||
|
||
<!-- Actually markdown --> | ||
```{python} ` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this also syntax i wasn't aware of? like an one-line code-fence?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No this is intentionally broken to make sure match works. The newest unit tests turned into more of smoke tests, so yeah- I think more granular tests would be awesome
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh gotcha, ha makes more sense
@@ -42,35 +43,60 @@ def _is_code_tag(text: str) -> bool: | |||
return bool(re.search(r"\{.*python.*\}", head)) | |||
|
|||
|
|||
def formatted_code_block(code: str) -> str: | |||
def formatted_code_block( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sometime this week - i may write some small unit tests for these files (as my way to learn this part of the code more)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛳️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
i can force merge past playwright - its been very flakey lately and i need to investigate |
The python 3.8 error is valid, but I won't be able to get to it for another hour or so |
@dmadisetti there is a snapshot fail on |
Oh woops. Weird, that's what I run |
Got it. Probably a bit of randomness. I think tempfile name gets quoted if it contains not path safe characters. Hopefully this won't be flaky- think I caught it locally. If it is I think it makes sens to just remove the line |
thanks @dmadisetti for more great work! |
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.4.12-dev15 |
I got
marimo edit document.md
working locally and realized a few things were missing:<!---->
The actual code to get
marimo edit document.md
working is a bit of a hack. Once this is in, I'll open the PR for reference, but I think that it will require a deeper rework from someone more versed in the internals