Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adding reactive html export #1360

Merged
merged 9 commits into from
May 19, 2024
Merged

feat: adding reactive html export #1360

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
257eaa2
adding reactive_html export
gvarnavi May 11, 2024
c7484e4
doctype to avoid quirks mode
gvarnavi May 14, 2024
bfc5862
respect config width
gvarnavi May 14, 2024
83acc9b
clarified help message
gvarnavi May 14, 2024
a88cedc
islands from_file static method
gvarnavi May 17, 2024
d2e0737
switching cli export to static method
gvarnavi May 17, 2024
0170e7a
adding ; between styles
gvarnavi May 18, 2024
a0d2963
removing exposing cli option
gvarnavi May 18, 2024
ee37ea8
Merge branch 'main' into gv/export-islands
mscolnick May 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 14 additions & 4 deletions marimo/_server/export/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ async def run_app_then_export_as_reactive_html(
include_code: bool,
) -> tuple[str, str]:
from marimo._islands.island_generator import MarimoIslandGenerator
from marimo._server.api.utils import parse_title
gvarnavi marked this conversation as resolved.
Show resolved Hide resolved
from marimo._server.export.utils import get_download_filename

# Create a file router and file manager
Expand All @@ -91,22 +92,31 @@ async def run_app_then_export_as_reactive_html(
)
)

island_file_manager = AppFileManager.from_app(generator._app)
app = generator._app
island_file_manager = AppFileManager.from_app(app)
session_view = await run_app_until_completion(
island_file_manager, cli_args={}
)

rendered_stubs = []
for stub in stubs:
stub._internal_app = generator._app
stub._internal_app = app
stub._session_view = session_view
rendered_stubs.append(stub.render())

head = generator.render_head()
title = (
parse_title(str(path.path))
if app.config.app_title is None
else app.config.app_title
)
body = "\n".join(rendered_stubs)
html = f"""
<html>

html = f"""<!doctype html>
<html lang="en">
<head>
<meta charset="UTF-8" />
<title> {title} </title>
{head}
</head>
<body>
Expand Down