Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Claims pipeline #3

Merged
merged 74 commits into from
Nov 27, 2023
Merged

Claims pipeline #3

merged 74 commits into from
Nov 27, 2023

Conversation

janlegner
Copy link
Collaborator

No description provided.

ochaloup
ochaloup approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@ochaloup ochaloup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through the code, to tell the truth I haven't dived to all details of the business logic, all is nice and neat.
I added few comments but all are just nitpicks with not a great relevance.

.buildkite/prepare-claims.yml Outdated Show resolved Hide resolved
insurance-engine/Cargo.toml Outdated Show resolved Hide resolved
snapshot-parser/src/validator_meta.rs Show resolved Hide resolved
snapshot-parser/src/utils.rs Show resolved Hide resolved
@janlegner janlegner merged commit 24e2723 into main Nov 27, 2023
1 check passed
@janlegner janlegner deleted the claims-pipeline branch November 27, 2023 16:37
ochaloup added a commit that referenced this pull request May 9, 2024
@ochaloup
closing #3
61f5ff6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ochaloup ochaloup ochaloup approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@janlegner @ochaloup