Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contract adjustments n1 #8

Merged
merged 6 commits into from
Dec 26, 2023
Merged

Contract adjustments n1 #8

merged 6 commits into from
Dec 26, 2023

Conversation

ochaloup
Copy link
Contributor

Contract adjustments. Continuation of #6

  • I realized a wrong usage of the API for Anchor errors. Information on error cause replaced with msg!. Maybe there is some nicer way, currently not sure about it.
  • minimumStakeLamports to be configurable as it's in liquid staking program. It seems to be reasonable as the final Solana changes are still not released
  • fixes with names of the events that were forgotten to be changed from the prior PR
  • disabling settlement related instructions. using return err! generates warnings of unreachable code. Used the require! but maybe there is some nicer way.

.with_values((
"minimal_size_stake_account",
minimal_size_stake_account(&stake_meta, &self.config),
"stake_account_lamports < amount + minimal_size_stake_account",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is awesome

@ochaloup ochaloup merged commit a72fa1b into main Dec 26, 2023
1 check failed
@ochaloup ochaloup deleted the contract-adjustments-n1 branch February 2, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants