Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolving of ModuleTypeRegistry by AbstractModuleHandler #48

Closed
BenediktNiehues opened this issue Aug 13, 2015 · 2 comments
Closed

Resolving of ModuleTypeRegistry by AbstractModuleHandler #48

BenediktNiehues opened this issue Aug 13, 2015 · 2 comments
Assignees

Comments

@BenediktNiehues
Copy link
Collaborator

The AbstractModuleHandler should resolve the ModuleTypeRegistry by itself during initialization. This reduces the overhead in the common implementations and makes the abstract method getModuleTypeRegistry obsolete.

@kaikreuzer
Copy link
Collaborator

I understand the concern of too many service trackers, if the handlers themselves deal with resolving the ModuleTypeRegistry.
Another option is to do the tracking only in the BaseModuleHandlerFactory (see #49) and have it injected into the ModuleHanders (possibly directly in the constructor)? Anyhow, some place needs to keep track of the Handlers and dispose them when their HandlerFactory or the ModuleTypeRegistry disappears. This place could also deal with injecting the ModuleTypeRegistry in the handlers. As we do not treat the handlers as OSGi services on their own, I think this procedure would make more sense than having an internal service tracker per handler.

@danchom
Copy link

danchom commented Aug 17, 2015

will be done

vilchev added a commit to vilchev/eclipse-smarthome that referenced this issue Aug 21, 2015
…dlerFactory

( marinmitev#48
marinmitev#49 )
Added BaseTriggerHandler for common implementation of TriggerHandler
Added BaseConditionHandler for common implementation of ConditionHandler
Added BaseActionHandler for common implementation of ActionHandler
(marinmitev#53)
Renamed AbstractModuleHandler -> BaseModuleHandler (keeping namescpace clean)
In BaseModuleHandler added implementation of custom 'context' language -> (a=b,c=d,e=(f=h))


Signed-off-by: Vasil Ilchev <v.ilchev@prosyst.bg>
vilchev added a commit to vilchev/eclipse-smarthome that referenced this issue Aug 24, 2015
…dlerFactory

( marinmitev#48
marinmitev#49 )
Added BaseTriggerHandler for common implementation of TriggerHandler
Added BaseConditionHandler for common implementation of ConditionHandler
Added BaseActionHandler for common implementation of ActionHandler
(marinmitev#53)
Renamed AbstractModuleHandler -> BaseModuleHandler (keeping namescpace clean)
In BaseModuleHandler added implementation of custom 'context' language -> (a=b,c=d,e=(f=h))


Signed-off-by: Vasil Ilchev <v.ilchev@prosyst.bg>
vilchev added a commit that referenced this issue Oct 9, 2015
…dlerFactory

( #48
#49 )
Added BaseTriggerHandler for common implementation of TriggerHandler
Added BaseConditionHandler for common implementation of ConditionHandler
Added BaseActionHandler for common implementation of ActionHandler
(#53)
Renamed AbstractModuleHandler -> BaseModuleHandler (keeping namescpace clean)
In BaseModuleHandler added implementation of custom 'context' language -> (a=b,c=d,e=(f=h))


Signed-off-by: Vasil Ilchev <v.ilchev@prosyst.bg>
vilchev added a commit that referenced this issue Oct 9, 2015
…dlerFactory

( #48
#49 )
Added BaseTriggerHandler for common implementation of TriggerHandler
Added BaseConditionHandler for common implementation of ConditionHandler
Added BaseActionHandler for common implementation of ActionHandler
(#53)
Renamed AbstractModuleHandler -> BaseModuleHandler (keeping namescpace clean)
In BaseModuleHandler added implementation of custom 'context' language -> (a=b,c=d,e=(f=h))


Signed-off-by: Vasil Ilchev <v.ilchev@prosyst.bg>
kaikreuzer pushed a commit to kaikreuzer/smarthome that referenced this issue Oct 15, 2015
…dlerFactory

( marinmitev#48
marinmitev#49 )
Added BaseTriggerHandler for common implementation of TriggerHandler
Added BaseConditionHandler for common implementation of ConditionHandler
Added BaseActionHandler for common implementation of ActionHandler
(marinmitev#53)
Renamed AbstractModuleHandler -> BaseModuleHandler (keeping namescpace clean)
In BaseModuleHandler added implementation of custom 'context' language -> (a=b,c=d,e=(f=h))


Signed-off-by: Vasil Ilchev <v.ilchev@prosyst.bg>
kaikreuzer pushed a commit to kaikreuzer/smarthome that referenced this issue Oct 15, 2015
…dlerFactory

( marinmitev#48
marinmitev#49 )
Added BaseTriggerHandler for common implementation of TriggerHandler
Added BaseConditionHandler for common implementation of ConditionHandler
Added BaseActionHandler for common implementation of ActionHandler
(marinmitev#53)
Renamed AbstractModuleHandler -> BaseModuleHandler (keeping namescpace clean)
In BaseModuleHandler added implementation of custom 'context' language -> (a=b,c=d,e=(f=h))


Signed-off-by: Vasil Ilchev <v.ilchev@prosyst.bg>
vilchev added a commit that referenced this issue Nov 13, 2015
…dlerFactory

( #48
#49 )
Added BaseTriggerHandler for common implementation of TriggerHandler
Added BaseConditionHandler for common implementation of ConditionHandler
Added BaseActionHandler for common implementation of ActionHandler
(#53)
Renamed AbstractModuleHandler -> BaseModuleHandler (keeping namescpace clean)
In BaseModuleHandler added implementation of custom 'context' language -> (a=b,c=d,e=(f=h))


Signed-off-by: Vasil Ilchev <v.ilchev@prosyst.bg>
vilchev added a commit that referenced this issue Nov 13, 2015
…dlerFactory

( #48
#49 )
Added BaseTriggerHandler for common implementation of TriggerHandler
Added BaseConditionHandler for common implementation of ConditionHandler
Added BaseActionHandler for common implementation of ActionHandler
(#53)
Renamed AbstractModuleHandler -> BaseModuleHandler (keeping namescpace clean)
In BaseModuleHandler added implementation of custom 'context' language -> (a=b,c=d,e=(f=h))


Signed-off-by: Vasil Ilchev <v.ilchev@prosyst.bg>
vilchev added a commit that referenced this issue Nov 23, 2015
…dlerFactory

( #48
#49 )
Added BaseTriggerHandler for common implementation of TriggerHandler
Added BaseConditionHandler for common implementation of ConditionHandler
Added BaseActionHandler for common implementation of ActionHandler
(#53)
Renamed AbstractModuleHandler -> BaseModuleHandler (keeping namescpace clean)
In BaseModuleHandler added implementation of custom 'context' language -> (a=b,c=d,e=(f=h))


Signed-off-by: Vasil Ilchev <v.ilchev@prosyst.bg>
vilchev added a commit that referenced this issue Nov 23, 2015
…dlerFactory

( #48
#49 )
Added BaseTriggerHandler for common implementation of TriggerHandler
Added BaseConditionHandler for common implementation of ConditionHandler
Added BaseActionHandler for common implementation of ActionHandler
(#53)
Renamed AbstractModuleHandler -> BaseModuleHandler (keeping namescpace clean)
In BaseModuleHandler added implementation of custom 'context' language -> (a=b,c=d,e=(f=h))


Signed-off-by: Vasil Ilchev <v.ilchev@prosyst.bg>
vilchev added a commit that referenced this issue Nov 23, 2015
…dlerFactory

( #48
#49 )
Added BaseTriggerHandler for common implementation of TriggerHandler
Added BaseConditionHandler for common implementation of ConditionHandler
Added BaseActionHandler for common implementation of ActionHandler
(#53)
Renamed AbstractModuleHandler -> BaseModuleHandler (keeping namescpace clean)
In BaseModuleHandler added implementation of custom 'context' language -> (a=b,c=d,e=(f=h))


Signed-off-by: Vasil Ilchev <v.ilchev@prosyst.bg>
vilchev added a commit that referenced this issue Nov 23, 2015
…dlerFactory

( #48
#49 )
Added BaseTriggerHandler for common implementation of TriggerHandler
Added BaseConditionHandler for common implementation of ConditionHandler
Added BaseActionHandler for common implementation of ActionHandler
(#53)
Renamed AbstractModuleHandler -> BaseModuleHandler (keeping namescpace clean)
In BaseModuleHandler added implementation of custom 'context' language -> (a=b,c=d,e=(f=h))


Signed-off-by: Vasil Ilchev <v.ilchev@prosyst.bg>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants