-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Improve focus/first responder handling in SwiftUI #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marinofelipe
force-pushed
the
feat/swift-ui-focus
branch
from
March 22, 2022 22:46
4e230e9
to
75b570b
Compare
Codecov Report
@@ Coverage Diff @@
## main #85 +/- ##
=======================================
Coverage ? 95.65%
=======================================
Files ? 22
Lines ? 1104
Branches ? 0
=======================================
Hits ? 1056
Misses ? 48
Partials ? 0 Continue to review full report at Codecov.
|
This was referenced Mar 24, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
To provide a better API for making CurrencyTextField the first responder in
SwiftUI
.Context
CurrencyTextField
is currently bridged fromUIKit
toSwiftUI
, so iOS 15's focus API doesn't work for it.The only way to make a
CurrencyTextField
the first responder programmatically is as indicated by YeungKC on #81:which is error prone and ugly.
Changes
This PR adds a new property to
CurrencyTextFieldConfiguration
calledhasFocus
, anOptionalBinding
to drive an listen to the first responder state of aCurrencyTextField
wrappedUITextField
.The usage is as follows:
Tests
Tests were updated and
CurrencyTextFieldConfigurationTests
was extended.Related issue: #81