Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed del to allow deletion of falsy values in array #12

Merged
merged 2 commits into from
Nov 21, 2016

Conversation

ftliou
Copy link
Contributor

@ftliou ftliou commented Nov 17, 2016

Modified del API to allow deletion of falsy values in array item.
Before: del([''], 0)).to.deep.equal([''])
After: del([''], 0)).to.deep.equal([])

@coveralls
Copy link

Coverage Status

Coverage increased (+0.007%) to 98.951% when pulling 893c0be on ftliou:fix-del into 0df5e92 on mariocasciaro:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.007%) to 98.951% when pulling 893c0be on ftliou:fix-del into 0df5e92 on mariocasciaro:master.

@mariocasciaro
Copy link
Owner

Thanks for the PR! Could you please fix the linting errors, please, so the build doesn't fail?

@coveralls
Copy link

coveralls commented Nov 18, 2016

Coverage Status

Coverage increased (+0.007%) to 98.951% when pulling 9a2fb0a on ftliou:fix-del into 0df5e92 on mariocasciaro:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.007%) to 98.951% when pulling 9a2fb0a on ftliou:fix-del into 0df5e92 on mariocasciaro:master.

@ftliou
Copy link
Contributor Author

ftliou commented Nov 18, 2016

Oops sorry. Done :)

@mariocasciaro
Copy link
Owner

Thanks a lot!!!

@mariocasciaro mariocasciaro merged commit 9561315 into mariocasciaro:master Nov 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants