added insert function #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| at = ~~at; | ||
| return changeImmutable(obj, path, function(clonedObj, finalPath) { | ||
| var arr = clonedObj[finalPath]; | ||
| if (!isArray(arr)) |
There was a problem hiding this comment.
We should force arr to be an array only if it's not set (NULL or undefined), we should throw an error instead if arr is set and it's not an Array, this will avoid silent bugs.
|
Hi Dave, thanks for the PR, it looks great. |
|
Does this address the concerns? |
|
Thanks a lot for the PR, merged now |
|
When you have some time could you please send another PR adding something in the readme to document the new function? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added similar functionality to object-path for inserting at an array index.