Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing mainMenuBar option #25

Closed
vrockai opened this issue Jan 16, 2019 · 3 comments
Closed

Missing mainMenuBar option #25

vrockai opened this issue Jan 16, 2019 · 3 comments

Comments

@vrockai
Copy link
Contributor

vrockai commented Jan 16, 2019

navigationBar and statusBar are inside the options class definition, but the mainMenuBar is missing:

ang-jsoneditor/ang-jsoneditor/src/jsoneditor/jsoneditor.component.ts

Line 205 in e3da72b

public navigationBar: boolean;

@mariohmol
Copy link
Owner

Hi.. can u make a PR? thanks

@vrockai
Copy link
Contributor Author

vrockai commented Jan 16, 2019

sure thing!

vrockai added a commit to vrockai/ang-jsoneditor that referenced this issue Jan 17, 2019
@vrockai
Add the missing mainMenuBar option, mariohmol#25
b485d56
mariohmol added a commit that referenced this issue Jan 17, 2019
@mariohmol
Merge pull request #29 from vrockai/feat/menubar/25
e317df0 
Add the missing mainMenuBar option, #25
@mariohmol
Copy link
Owner

included in v 1.7.2

thanks a lot @vrockai !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vrockai @mariohmol