Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support for MOI.TimeLimitSec #101

Merged
merged 6 commits into from
Jan 10, 2024
Merged

Conversation

odow
Copy link
Contributor

@odow odow commented Aug 17, 2023

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.14% 🎉

Comparison is base (df1d1f1) 82.26% compared to head (f5508b6) 82.41%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
+ Coverage   82.26%   82.41%   +0.14%     
==========================================
  Files          12       12              
  Lines        1269     1274       +5     
==========================================
+ Hits         1044     1050       +6     
+ Misses        225      224       -1     
Files Changed Coverage Δ
src/MOI_wrapper.jl 94.14% <100.00%> (+0.13%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matbesancon
Copy link

the issue here seems to go beyond the time limit?

@odow odow closed this Sep 6, 2023
@odow odow reopened this Sep 6, 2023
@odow
Copy link
Contributor Author

odow commented Sep 6, 2023

Seems unrelated? Dunno

@matbesancon
Copy link

maybe open a PR not changing the code and see if CI is still breaking, in which case we can merge the MOI one.
ping @joaquimg

@odow
Copy link
Contributor Author

odow commented Sep 14, 2023

Same failure is here: #100

test/moitest.jl Outdated Show resolved Hide resolved
test/moitest.jl Outdated Show resolved Hide resolved
@odow
Copy link
Contributor Author

odow commented Sep 27, 2023

Bump @joaquimg

@joaquimg joaquimg merged commit 3afc98c into mariohsouto:master Jan 10, 2024
6 checks passed
@odow odow deleted the od/time-limit branch January 11, 2024 01:10
@odow odow mentioned this pull request Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants