disabled checkbox should not have unchecked value #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. |
|
Sorry missed the contribution paragraph yesterday. I added a single test for both normal disabled checkbox and disabled checkbox with data-unchecked-value="NOPE" attribute. |
|
Nice. I'm merging it and creating the new release with it. |
marioizquierdo
added a commit
that referenced
this pull request
Feb 4, 2015
disabled checkbox should not have unchecked value
|
Ups, I didn't realize but this change breaks compatibility with Zepto, because Zepto doesn't support the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabled elements should not be serialised. The selector for checkbox unchecked values was missing a disabled exclusion. This change prevents disabled checkboxes with default unchecked values from being serialized.