Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable multi-element instances #63 #72

Merged
merged 1 commit into from
Nov 16, 2015

Conversation

marionebl
Copy link
Owner

This allows for instantiation of JogWheel on NodeLists and Nodes.

Changes:

  • Rename first parameter of constructor to node
  • Normalize node to Array
  • Move all "private" members to this.__instance
  • Add playState and currentTime getters
  • Modify tests to fit extended API
  • Modify writing methods to fit new internal data structures

@marionebl
Copy link
Owner Author

#63

Repository owner locked and limited conversation to collaborators Nov 15, 2015
@marionebl marionebl force-pushed the feat/multi-element-instance branch 4 times, most recently from 1648894 to 7bada52 Compare November 15, 2015 18:29
Repository owner unlocked this conversation Nov 16, 2015
marionebl added a commit that referenced this pull request Nov 16, 2015
@marionebl marionebl merged commit 264a675 into master Nov 16, 2015
@marionebl marionebl deleted the feat/multi-element-instance branch November 16, 2015 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant