Not replacement itemView -> childView

[ryotakato]

Hi, This is Nice tool ! Thank you.

I try change Marionette 1.8 -> Marionette 2.2.
But did'nt replace "itemView" to "childVIew" in CollectionView .

Code is

  return Backbone.Marionette.CollectionView.extend({
    itemView: SampleView,
    tagName:"ul",
    initialize: function() {
    }
  });

Why not ? Colon ?

[jamesplease]

You said it yourself, the new attribute name is childView. Change that, and it should work.

[jamiebuilds]

uh @jmeas if the upgrade script didnt do that dont you think thats worth looking into?

[jamesplease]

Ah misread the issue!

[ryotakato]

Sorry, do not have enough words.

[jamesplease]

Nah it's my fault @ryotakato. I shouldn't reply from my iPhone when I'm out buying groceries :P

[jasonLaster]

@ryotakato thanks for making the issue. The tool should absolutely catch this. Because it's actually one small Python file with some regexes, id appreciate it if you took a look. The easiest thing to do is comment out the irrelevant ones and see what happens.

[ryotakato]

I tryed.
And to keep apologized earlier.

In Using of README.md

$ ./upgrade.py PATH_TO_PROJECT_DIR

But I have tryed

$ ./Marionette.Upgrade/upgrade.py PATH_TO_PROJECT_DIR

so, I didn't notice to following sentence.

sh: ./bin/codemod.py: No such file or directory

I'm sorry to be fuss.

How about that change upgrade.py ? like this,

codemod = "./bin/codemod.py"

to

codemod = "%s/bin/codemod.py" %  path.dirname(__file__)

[jasonLaster]

Sure. PR it up

[samccone]

👍

[ryotakato]

This is my first pull request.
Thank you, for @jmeas , @thejameskyle , @jasonLaster , @samccone

[jasonLaster]

Got it! Welcome to OSS

[ryotakato]

Thanks !