New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not replacement itemView -> childView #35

Closed
ryotakato opened this Issue Feb 7, 2015 · 12 comments

Comments

Projects
None yet
5 participants
@ryotakato
Contributor

ryotakato commented Feb 7, 2015

Hi, This is Nice tool ! Thank you.

I try change Marionette 1.8 -> Marionette 2.2.
But did'nt replace "itemView" to "childVIew" in CollectionView .

Code is

  return Backbone.Marionette.CollectionView.extend({
    itemView: SampleView,
    tagName:"ul",
    initialize: function() {
    }
  });

Why not ? Colon ?

@jamesplease

This comment has been minimized.

Show comment
Hide comment
@jamesplease

jamesplease Feb 7, 2015

Member

You said it yourself, the new attribute name is childView. Change that, and it should work.

Member

jamesplease commented Feb 7, 2015

You said it yourself, the new attribute name is childView. Change that, and it should work.

@jamesplease jamesplease closed this Feb 7, 2015

@jamiebuilds

This comment has been minimized.

Show comment
Hide comment
@jamiebuilds

jamiebuilds Feb 7, 2015

Member

uh @jmeas if the upgrade script didnt do that dont you think thats worth looking into?

Member

jamiebuilds commented Feb 7, 2015

uh @jmeas if the upgrade script didnt do that dont you think thats worth looking into?

@jamesplease

This comment has been minimized.

Show comment
Hide comment
@jamesplease

jamesplease Feb 7, 2015

Member

Ah misread the issue!

Member

jamesplease commented Feb 7, 2015

Ah misread the issue!

@jamesplease jamesplease reopened this Feb 7, 2015

@ryotakato

This comment has been minimized.

Show comment
Hide comment
@ryotakato

ryotakato Feb 8, 2015

Contributor

Sorry, do not have enough words.

Contributor

ryotakato commented Feb 8, 2015

Sorry, do not have enough words.

@jamesplease

This comment has been minimized.

Show comment
Hide comment
@jamesplease

jamesplease Feb 8, 2015

Member

Nah it's my fault @ryotakato. I shouldn't reply from my iPhone when I'm out buying groceries :P

Member

jamesplease commented Feb 8, 2015

Nah it's my fault @ryotakato. I shouldn't reply from my iPhone when I'm out buying groceries :P

@jasonLaster

This comment has been minimized.

Show comment
Hide comment
@jasonLaster

jasonLaster Feb 8, 2015

Member

@ryotakato thanks for making the issue. The tool should absolutely catch this. Because it's actually one small Python file with some regexes, id appreciate it if you took a look. The easiest thing to do is comment out the irrelevant ones and see what happens.

Member

jasonLaster commented Feb 8, 2015

@ryotakato thanks for making the issue. The tool should absolutely catch this. Because it's actually one small Python file with some regexes, id appreciate it if you took a look. The easiest thing to do is comment out the irrelevant ones and see what happens.

@ryotakato

This comment has been minimized.

Show comment
Hide comment
@ryotakato

ryotakato Feb 9, 2015

Contributor

I tryed.
And to keep apologized earlier.

In Using of README.md

$ ./upgrade.py PATH_TO_PROJECT_DIR

But I have tryed

$ ./Marionette.Upgrade/upgrade.py PATH_TO_PROJECT_DIR

so, I didn't notice to following sentence.

sh: ./bin/codemod.py: No such file or directory

I'm sorry to be fuss.

How about that change upgrade.py ? like this,

codemod = "./bin/codemod.py"

to

codemod = "%s/bin/codemod.py" %  path.dirname(__file__)
Contributor

ryotakato commented Feb 9, 2015

I tryed.
And to keep apologized earlier.

In Using of README.md

$ ./upgrade.py PATH_TO_PROJECT_DIR

But I have tryed

$ ./Marionette.Upgrade/upgrade.py PATH_TO_PROJECT_DIR

so, I didn't notice to following sentence.

sh: ./bin/codemod.py: No such file or directory

I'm sorry to be fuss.

How about that change upgrade.py ? like this,

codemod = "./bin/codemod.py"

to

codemod = "%s/bin/codemod.py" %  path.dirname(__file__)
@jasonLaster

This comment has been minimized.

Show comment
Hide comment
@jasonLaster

jasonLaster Feb 9, 2015

Member

Sure. PR it up

Member

jasonLaster commented Feb 9, 2015

Sure. PR it up

@samccone

This comment has been minimized.

Show comment
Hide comment
@samccone

samccone Feb 9, 2015

Member

👍

Member

samccone commented Feb 9, 2015

👍

@ryotakato

This comment has been minimized.

Show comment
Hide comment
@ryotakato

ryotakato Feb 10, 2015

Contributor

This is my first pull request.
Thank you, for @jmeas , @thejameskyle , @jasonLaster , @samccone

Contributor

ryotakato commented Feb 10, 2015

This is my first pull request.
Thank you, for @jmeas , @thejameskyle , @jasonLaster , @samccone

@jasonLaster

This comment has been minimized.

Show comment
Hide comment
@jasonLaster

jasonLaster Feb 11, 2015

Member

Got it! Welcome to OSS

Member

jasonLaster commented Feb 11, 2015

Got it! Welcome to OSS

@ryotakato

This comment has been minimized.

Show comment
Hide comment
@ryotakato

ryotakato Feb 11, 2015

Contributor

Thanks !

Contributor

ryotakato commented Feb 11, 2015

Thanks !

@ryotakato ryotakato closed this Feb 11, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment