Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jQuery dependency in bower.json limited to version range 1.8.0-2.1.0 #1762

Closed
radkodinev opened this issue Aug 25, 2014 · 5 comments
Closed

jQuery dependency in bower.json limited to version range 1.8.0-2.1.0 #1762

radkodinev opened this issue Aug 25, 2014 · 5 comments
Milestone
v2.2

Comments

@radkodinev
Copy link

Is there any reason to have jQuery limited in bower.json to version 2.1.0 at most?

Bower complains upon bower install --save jquery with:

Unable to find a suitable version for jquery, please choose one:
1) jquery#1.8.0 - 2.1.0 which resolved to 2.1.0 and is required by marionette#2.1.0
2) jquery#~2.1.1 which resolved to 2.1.1
Prefix the choice with ! to persist it to bower.json
[?] Answer:
@samccone
Copy link
Member

I think we can bump the jquery dep to - ~2.1.x thoughts @marionettejs/marionette-core

@jamesplease
Copy link
Member

I still think we can do 2.x since they still follow semver

:P

@samccone
Copy link
Member

k

@samccone samccone mentioned this issue Aug 30, 2014
Merged
@jasonLaster jasonLaster modified the milestone: v2.2 Aug 30, 2014
@samccone samccone closed this as completed Sep 1, 2014
@samccone
Copy link
Member

samccone commented Sep 1, 2014

Fixed in #1778

@radkodinev
Copy link
Author

Great, thanks guys :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.2
Development

No branches or pull requests
5 participants
@jasonLaster @samccone @jamiebuilds @radkodinev @jamesplease