-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loosen jquery dep #1778
Loosen jquery dep #1778
Conversation
@@ -68,7 +68,7 @@ | |||
"grunt-plato": "~0.1.4", | |||
"grunt-preprocess": "~4.0.0", | |||
"grunt-template": "^0.2.3", | |||
"jquery": "^2.1.1", | |||
"jquery": "^2.x", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so the 2.x
change makes sense, but why doesn't this accept the same range as bower?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If i recall it is due to some contrived differences between how bower.json and package.json are parsed.
There is already an issue open about that and PLENTY of other issues discussing these things so heh lets dont worry about it in this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't I ever remember why we went with something? This seems blatantly wrong.
👍 |
3d7752f
to
e2ee125
Compare
all updated |
Marionette Supports jQuery 1.8 up to 2.X, since jquery is following semver for the 2.x branch we are safe to assume that all is going to be fine using a range.
Thus we need
|
e2ee125
to
9716e06
Compare
👍 Looks good! |
👍 |
Fixes #1762