Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow override of rendering after a collection sort #1645

Merged
merged 2 commits into from Jul 21, 2014

Conversation

ahumphreys87
Copy link
Member

Fixes: #1570

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) when pulling 6d8b7b8 on ahumphreys87:compositeSortRender into 719b300 on marionettejs:v2.1.

@jasonLaster
Copy link
Member

Nice

@samccone samccone added this to the v2.1 milestone Jul 14, 2014
@samccone samccone added the minor label Jul 14, 2014
@samccone
Copy link
Member

we neeeed some tests to add a hard assertion about the API otherwise we are in the weeds

@ahumphreys87
Copy link
Member Author

Oh damn I forgot tests! :o

On Tuesday, 15 July 2014, Sam Saccone notifications@github.com wrote:

we neeeed some tests to add a hard assertion about the API otherwise we
are in the weeds


Reply to this email directly or view it on GitHub
#1645 (comment)
.

@samccone
Copy link
Member

🎀

@ahumphreys87
Copy link
Member Author

@samccone updated - also fixed a bug I noticed in the orderChanged logic which was highlight by the tests from @thejameskyle

@samccone
Copy link
Member

👍

@jfairbank
Copy link
Member

Rebase please

@samccone
Copy link
Member

Rébase plzzz

@jamesplease
Copy link
Member

👍 to move to 2.2

@samccone
Copy link
Member

I want to get this in the 2.1 release because it is a problem that users have reported as being a pain point in 2

@jamiebuilds
Copy link
Member

@samccone we need to get 2.1 out the door. I think we should move everything still open into 2.2

@samccone
Copy link
Member

This just needs a rebase, it has already been through a review cycle

@samccone
Copy link
Member

the prerelease comes out tomorrow and if we find issues we can address them

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) when pulling 522fa3b on ahumphreys87:compositeSortRender into 60d75b2 on marionettejs:v2.1.

@samccone
Copy link
Member

👍

## CollectionView's resortView

By default the `CollectionView` will maintain the order of its `collection`
in the DOM, however on occasions the view may need to re-render to make this
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

, -> .

@jfairbank
Copy link
Member

👍

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) when pulling b3615db on ahumphreys87:compositeSortRender into 60d75b2 on marionettejs:v2.1.

@samccone samccone merged commit b3615db into marionettejs:v2.1 Jul 21, 2014
stephanebachelier added a commit to stephanebachelier/backbone.marionette that referenced this pull request Nov 10, 2014
stephanebachelier added a commit to stephanebachelier/backbone.marionette that referenced this pull request Nov 10, 2014
@stephanebachelier
Copy link
Contributor

sorry for the noise. I wanted to link to the issue 1685

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants